Gurobi: Add missing TAN operation code in nonlinear expressions #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other trigonometric operations are there but tan was probably overlooked.
Contributor
|
Hi, We must have thought on SCIP which has no Tan. What are the models (yfit, yfitu, cragglvy)? |
Contributor
Author
Sorry I misread the question probably. Those are from the CUTE set there are models there: https://vanderbei.princeton.edu/ampl/nlmodels/cute/index.html |
Contributor
|
Thank you, I thought the models were in a Gurobi format (don't know all instances in CUTE - thank you for reminding) BTW the update is released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
When looking at the code, I noticed that Tan was probably missing in the Gurobi driver?
I tested the change on a few cute models that were indeed not correctly converted (yfit, yfitu, cragglvy)