Skip to content

Conversation

@aalavandhan
Copy link
Member

  • Removed all string require errors in favor of solidity custom errors
  • Updated fee policy interface with redundant computeDeviationRatio methods
  • Perp interface cleanup, skipping update state when system is paused
  • Vault interface cleanup, caching and dust handling
  • Unit tests

Copy link
Member

@brandoniles brandoniles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the first commit, bccbb8b

Copy link
Member

@brandoniles brandoniles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For #2, 5c12093

Base automatically changed from v2-wraps to dev January 20, 2024 01:58
Copy link
Member

@brandoniles brandoniles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For #3, ce60170

Copy link
Member

@brandoniles brandoniles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For #4, e0b74e5

Copy link
Member

@brandoniles brandoniles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For #5, 294b89e

Copy link
Member

@brandoniles brandoniles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Do you know the code coverage after these unit tests?

@aalavandhan
Copy link
Member Author

Should be pretty close to 100%.. we'll know when the ci runs

@aalavandhan aalavandhan merged commit ada8cc5 into dev Jan 26, 2024
@aalavandhan aalavandhan deleted the v2-unit-tests branch April 5, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants