Skip to content

Charm Vault manager update #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aalavandhan merged 7 commits into from
Aug 7, 2024
Merged

Charm Vault manager update #217

aalavandhan merged 7 commits into from
Aug 7, 2024

Conversation

@aalavandhan
Copy link
Member

@aalavandhan aalavandhan commented Jul 26, 2024 •
edited
Loading

  • Fixed couple of minor bugs in the wampl-weth vault manager implementation. 1) Force rebalancing when limit ranges change. 2) Handling invalid oracle data, winding down to inf range. 3) Removing limit ranges completely instead of narrow/wide
  • Added a new auto manager for the SPOT-USDC charm vault. (mostly similar to wampl-weth, but adjusts liquidity based on SPOT's deviation from FMV)

@aalavandhan aalavandhan requested review from brandoniles and nms-7 July 26, 2024 20:41
@openzeppelin-code
Copy link

openzeppelin-code bot commented Jul 26, 2024 •
edited
Loading

Charm Vault manager update

Generated at commit: 14aeb18e890a1b75dff27293e4fb88568b46e60a

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 0
0
0
3
23
26
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

brandoniles
brandoniles reviewed Aug 1, 2024
View reviewed changes
spot-vaults/contracts/UsdcSpotManager.sol

VAULT = vault_;
POOL = vault_.pool();
USDC = vault_.token0();
Copy link
Member

@brandoniles brandoniles Aug 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably better style to hardcode the expected token addresses, then do a require check on the vault properties on init.

Nothing inherently incorrect with this approach, provided we do a manual spot check on deployment.

brandoniles
brandoniles reviewed Aug 5, 2024
View reviewed changes
Copy link
Member

@brandoniles brandoniles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just the comment update and looks good

@aalavandhan aalavandhan merged commit 654ffc5 into main Aug 7, 2024
@aalavandhan aalavandhan deleted the vault-update branch August 7, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandoniles brandoniles brandoniles approved these changes

@nms-7 nms-7 Awaiting requested review from nms-7

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aalavandhan @brandoniles