Pair operations #247
Merged
Pair operations #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pair operations
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
aalavandhan
force-pushed
the
rollover-fee-removal
branch
3 times, most recently
from
6e43a45 to
0fc7733
Compare
aalavandhan
added
WIP
brandoniles
reviewed
Apr 3, 2025
Member
brandoniles
left a comment
brandoniles
left a comment
There was a problem hiding this comment.
I'd like to talk about the ratio computation strategy before digging into the mint2 & redeem2 functions themselves. But here are some comments from an initial pass.
On naming:
Using the term "note" to describe the vault is ambiguous, since perp is technically also a note. We should call the rotation vault notes something more specific, like maybe "stAMPL" or "rolloverVaultNotes".
Then see also the difference between redemption and burning.
brandoniles
reviewed
Apr 17, 2025
Co-authored-by: Brandon Iles <brandon@fragments.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mint2 & Redeem2 => Ability to mint/redeem spot and stampl as matching pairs.