fix: allow empty import without error, fix search index export on accounts where it is disabled#125
Merged
Merged
Conversation
easen-amp
requested changes
Feb 1, 2022
| try { | ||
| allStoredIndexes = await paginator(searchIndexList(hub)); | ||
| } catch (e) { | ||
| log.warn('Could not get Search Indexes for the given hub - they may be disabled.', e); |
Member
There was a problem hiding this comment.
You should check the HAL link on the hub to see if search-indexes are available for that given Hub.
Contributor
Author
There was a problem hiding this comment.
The management sdk seems to report that _links is a Map<..>, but it's just a regular object. I've done this, but I had to cast _links to any to get it.
Contributor
Author
There was a problem hiding this comment.
Actually, can just use hasOwnProperty with no need to cast.
easen-amp
approved these changes
Apr 8, 2022
mdinning-amp
approved these changes
May 5, 2022
Pureball
pushed a commit
to cosnova/dc-cli
that referenced
this pull request
Aug 22, 2023
…ounts where it is disabled (amplience#125) This PR fixes an issue where empty import on certain commands would cause the command to error out, which would interrupt the clone command despite the import technically succeeding (as it didn't have to do anything). This also fixes an issue where search index list would throw an exception if it is disabled on the target account. In this case, the export is now simply skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where empty import on certain commands would cause the command to error out, which would interrupt the clone command despite the import technically succeeding (as it didn't have to do anything).
This also fixes an issue where search index list would throw an exception if it is disabled on the target account. In this case, the export is now simply skipped.