Skip to content

feat: use facet request to reduce content fetched when facets in use#128

Merged
rs-amp merged 6 commits into
amplience:masterfrom
rs-amp:feature/facet-fast
May 5, 2022
Merged

feat: use facet request to reduce content fetched when facets in use#128
rs-amp merged 6 commits into
amplience:masterfrom
rs-amp:feature/facet-fast

Conversation

@rs-amp
Copy link
Copy Markdown
Contributor

@rs-amp rs-amp commented Mar 1, 2022

Currently, all requests to archive or export content items fetch all content at a given folder, repo or even hub. The fetched content is then reduced in software, though this is obviously after we already have everything.

This PR accelerates certain types of facet requests, so that their content is not fetched at all.

(description being written).

This acceleration does not activate all the time - there are a few caveats:

  • For the content item export command, requesting content by facet means that individual requests have to be made to request the content body, so a decision is made to request all content vs the faceted content + individual matches depending on the number of faceted matches returned by the server.
  • Complex regex is not supported. Only exact match /^like this$|^with multiple$/ and simple partial match /(like this \(with escaped special characters\))|(multiple) on most fields. Details to be filled out later.
    • schema, locale can only be accelerated when searching with exact match.

Comment thread src/commands/content-item/archive.ts
@rs-amp rs-amp merged commit 34e5223 into amplience:master May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants