feat: concurrent publish queue with --batchPublish option#146
Merged
Conversation
This reverts commit 8aa6f9b.
neilmistryamplience
approved these changes
Sep 7, 2022
Collaborator
neilmistryamplience
left a comment
neilmistryamplience
left a comment
There was a problem hiding this comment.
Reviewed internally by Neil K& Reza
petercoulton
approved these changes
Sep 12, 2022
Member
|
As the API limit is 100 per minute per company, if a user was to publish a single item while someone else was running this dc-cli script with the Would it not be better to run at lower speed to allow other users of the company to also publish content items? |
Pureball
pushed a commit
to cosnova/dc-cli
that referenced
this pull request
Aug 22, 2023
) This is an alternative implementation to amplience#145 which extends the existing publishing queue to support concurrent publishes. Benefits: - Publish() method actually starts the publish, dispatching is limited by both the rate limit and the concurrency limit. - Not too much change from the existing publish queue. Downsides: - Custom implementation of batching rather than a standard one, though this was technically already in place originally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative implementation to #145 which extends the existing publishing queue to support concurrent publishes.
Benefits:
Downsides: