feat(hub): add environment management commands#149
Merged
Conversation
this commit adds the commands 'hub ls', 'hub add', and 'hub use' which manipulate dc-cli-config.json
rs-amp
reviewed
Sep 26, 2022
rs-amp
reviewed
Sep 26, 2022
Contributor
rs-amp
left a comment
rs-amp
left a comment
There was a problem hiding this comment.
Looks good. Just a few minor comments.
| @@ -1,5 +1,7 @@ | |||
| import { Argv } from 'yargs'; | |||
| import { readConfig } from '../cli'; | |||
Contributor
There was a problem hiding this comment.
Maybe readConfig should be moved to ./configure.
| const mockedWriteFileSync = jest.spyOn(fs, 'writeFileSync'); | ||
| jest.spyOn(fs, 'existsSync').mockReturnValueOnce(true); | ||
| await HubManager.addHub({ ...yargArgs, ...DummyHub }); | ||
| expect(mockedWriteFileSync).toHaveBeenCalled(); |
Contributor
There was a problem hiding this comment.
Check arguments? Might be harder as this one writes JSON.
rs-amp
changed the title
petercoulton
approved these changes
Oct 19, 2022
Pureball
pushed a commit
to cosnova/dc-cli
that referenced
this pull request
Aug 22, 2023
this commit adds the commands 'hub ls', 'hub add', and 'hub use' which manipulate dc-cli-config.json * chore: add @types/node * chore: remove yaml configuration support for node 12, update documentation * build(nodejs): removed nodejs 12.x support and added nodejs 18.x * build: require node 14 Co-authored-by: rs-amp <rsimpson@amplience.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this commit adds the commands 'hub ls', 'hub add', and 'hub use' which manipulate dc-cli-config.json