fix(content-item): only assume links will be published, not references#150
Merged
Conversation
petercoulton
approved these changes
Oct 19, 2022
rs-amp
force-pushed
the
fix/ref-publish
branch
from
9a6069e to
a89a232
Compare
Pureball
pushed a commit
to cosnova/dc-cli
that referenced
this pull request
Aug 22, 2023
amplience#150) * fix(content-item): only assume links will be published, not references * test(content-item): add tests for traversing only link dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code to skip publishing child items assumed that both content links and content references would be followed and published when their parent is, but that is only the case for links. This fixes the issue, and adds a test to verify that traversal only follows links when asked to.