fix(content-item): enrich items when faceting for archive#152
Merged
Conversation
petercoulton
approved these changes
Oct 19, 2022
rs-amp
force-pushed
the
fix/facet-archive
branch
from
d86508f to
0b81905
Compare
rs-amp
force-pushed
the
fix/facet-archive
branch
from
0b81905 to
87380a8
Compare
Pureball
pushed a commit
to cosnova/dc-cli
that referenced
this pull request
Aug 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the content-item archive command would error if the facet used could be accelerated.
The problem is that we need the content body to determine if the delivery-key is present, which is used to determine if it is to be removed on archive. This is not available when content is retrieved from the facet endpoint, so it was erroring instead.
The downside is that this might make content-item archive a little slower than it would be without the delivery key check, but this ensures that it works the same with and without the facet.