fix(events): correctly archive events with unscheduled editions#159
Merged
Conversation
neilmistryamplience
approved these changes
Oct 27, 2022
Collaborator
neilmistryamplience
left a comment
neilmistryamplience
left a comment
There was a problem hiding this comment.
Reviewed and approved
petercoulton
approved these changes
Oct 27, 2022
petercoulton
approved these changes
Oct 27, 2022
Pureball
pushed a commit
to cosnova/dc-cli
that referenced
this pull request
Aug 22, 2023
…ence#159) * fix(event): correctly archive events with unscheduled editions * fix(event): wait for unschedule to complete before deleting editions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To archive events, all contained editions must be archived. However, if an edition has never been published (its scheduled time never arrived) then it cannot be archived. The correct process here is unscheduling the edition, then deleting it, though only the first part was done which would result in an error. This PR fixes the issue.