Amp 145286 use pnpm #1445
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -121,7 +121,7 @@ jobs: | |
|
|
||
| # Setup Node.js environment | ||
| - name: Setup Node.js ${{ matrix.node-version }} | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -50,7 +50,7 @@ jobs: | |
| key: ${{ runner.os }}-modules-${{ hashFiles('**/yarn.lock') }} | ||
|
|
||
| - name: Setup Node.js ${{ matrix.node-version }} | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| #!/bin/sh | ||
| . "$(dirname "$0")/_/husky.sh" | ||
|
|
||
| pnpm commitlint --edit $1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| #!/bin/sh | ||
| . "$(dirname "$0")/_/husky.sh" | ||
|
|
||
| pnpm lint:staged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,13 +7,13 @@ This repository uses GitHub Actions for continuous integration. Contributors sho | |
| Before running any tests or scripts, install dependencies and build the packages: | ||
|
|
||
| ```bash | ||
| pnpm install | ||
| yarn build | ||
| ``` | ||
|
|
||
| ## Testing and Linting | ||
|
|
||
| 1. Install dependencies with `pnpm install`. | ||
| 2. Build all packages with `yarn build`. | ||
| 3. Verify documentation with `yarn docs:check`. | ||
| 4. Run unit tests with `yarn test` and example tests with `yarn test:examples`. | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,8 +24,8 @@ Getting setup is quick and easy. Follow the steps below to get your your dev env | |
|
|
||
| ``` | ||
| $ git clone <HTTPS_OR_GIT_URL> | ||
| $ pnpm install | ||
| $ pnpm build | ||
| ``` | ||
|
|
||
| This repo contains mutliple major versions of all packages. For contributions to version `1.x`, create a branch off `v1.x`. For contributions to the `2.x` (latest) version, create a branch off `main`. Refer to the table below for more infomation about the release status of each package. | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -92,5 +92,5 @@ | |
| "dependencies": { | ||
| "tslib": "^2.4.1" | ||
| }, | ||
| "packageManager": "pnpm@10.26.1+sha512.664074abc367d2c9324fdc18037097ce0a8f126034160f709928e9e9f95d98714347044e5c3164d65bd5da6c59c6be362b107546292a8eecb7999196e5ce58fa" | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,9 +16,10 @@ | |
| "url": "https://github.com/amplitude/Amplitude-TypeScript/issues" | ||
| }, | ||
| "dependencies": { | ||
| }, | ||
| "devDependencies": { | ||
| "@amplitude/analytics-browser": "workspace:*", | ||
| "@amplitude/analytics-core": "workspace:*", | ||
| "nock": "^13.2.4" | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,7 @@ | ||
| /* eslint-disable @typescript-eslint/no-unsafe-call */ | ||
| /* eslint-disable @typescript-eslint/no-unsafe-member-access */ | ||
| /* eslint-disable @typescript-eslint/no-unsafe-assignment */ | ||
| import { BaseEvent, Campaign, BASE_CAMPAIGN } from '@amplitude/analytics-core'; | ||
| import { uuidPattern } from './constants'; | ||
|
|
||
| const uuid: string = expect.stringMatching(uuidPattern) as string; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,7 +6,7 @@ import { default as nock } from 'nock'; | |
| import { success } from './responses'; | ||
| import 'isomorphic-fetch'; | ||
| import { path, url, SUCCESS_MESSAGE, uuidPattern } from './constants'; | ||
| import { LogLevel } from '@amplitude/analytics-core'; | ||
| import { UUID } from '@amplitude/analytics-core'; | ||
|
|
||
| describe('integration', () => { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,37 +22,37 @@ | |
| "url": "git+https://github.com/amplitude/Amplitude-TypeScript.git" | ||
| }, | ||
| "scripts": { | ||
| "build": "pnpm bundle && pnpm build:es5 && pnpm build:esm", | ||
| "bundle": "rollup --config rollup.config.js", | ||
| "build:es5": "tsc -p ./tsconfig.es5.json", | ||
| "build:esm": "tsc -p ./tsconfig.esm.json", | ||
| "watch": "tsc -p ./tsconfig.esm.json --watch", | ||
| "clean": "rimraf node_modules lib coverage", | ||
| "fix": "pnpm fix:eslint & pnpm fix:prettier", | ||
| "fix:eslint": "eslint '{src,test}/**/*.ts' --fix", | ||
| "fix:prettier": "prettier --write \"{src,test}/**/*.ts\"", | ||
| "lint": "pnpm lint:eslint & pnpm lint:prettier", | ||
| "lint:eslint": "eslint '{src,test}/**/*.ts'", | ||
| "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"", | ||
| "playground:html": "cp lib/scripts/amplitude-min.js playground/html/amplitude.js && http-server ./playground/html", | ||
| "playground:react-spa": "cp lib/scripts/amplitude-min.js playground/react-spa/public/amplitude.js && cd ./playground/react-spa && pnpm install && pnpm start", | ||
| "publish": "node ../../scripts/publish/upload-to-s3.js", | ||
| "test": "jest", | ||
| "test:playwright": "playwright test", | ||
| "typecheck": "tsc -p ./tsconfig.json", | ||
| "version": "pnpm version-file && GENERATE_SNIPPET=true pnpm build && cp lib/scripts/amplitude-min.js playground/html/amplitude.js && cp lib/scripts/amplitude-min.js playground/react-spa/public/amplitude.js", | ||
| "version-file": "node -p \"'export const VERSION = \\'' + require('./package.json').version + '\\';'\" > src/version.ts" | ||
| }, | ||
| "bugs": { | ||
| "url": "https://github.com/amplitude/Amplitude-TypeScript/issues" | ||
| }, | ||
| "dependencies": { | ||
| "@amplitude/analytics-core": "workspace:*", | ||
| "@amplitude/plugin-autocapture-browser": "workspace:*", | ||
| "@amplitude/plugin-network-capture-browser": "workspace:*", | ||
| "@amplitude/plugin-page-url-enrichment-browser": "workspace:*", | ||
| "@amplitude/plugin-page-view-tracking-browser": "workspace:*", | ||
| "@amplitude/plugin-web-vitals-browser": "workspace:*", | ||
| "tslib": "^2.4.1" | ||
| }, | ||
| "devDependencies": { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| import { InstanceProxy } from '@amplitude/analytics-core'; | ||
|
|
||
| declare global { | ||
| // globalThis only includes `var` declarations | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build action uses pnpm without installing it first
The composite action was updated to use
pnpm install,pnpm build,pnpm test, andpnpm lintcommands, but no step was added to install pnpm (usingpnpm/action-setup@v4). Thepublish-v2.ymlworkflow uses this action without setting up pnpm first, which will cause the publish workflow to fail with "command not found" errors. Other workflows likeci.ymlandci-nx.ymlwere correctly updated to include the pnpm setup step, but this action was not.