Skip to content

Conversation

@daniel-graham-amplitude
Copy link
Collaborator

@daniel-graham-amplitude daniel-graham-amplitude commented Dec 24, 2025

Summary

This PR updates versions in package.json to use "workspace:*" when it's an internal package. This is so that it uses the internal package instead of fetching it from the NPM repository.

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: No

Note

Adopts pnpm workspaces and links internal packages via workspace:*, updating tooling and minor code to align with the new setup.

  • Switches repo to pnpm: set npmClient to pnpm in lerna.json, add pnpm setup/caching to .github/actions/build-and-test, run pnpm install in .husky/pre-commit, tweak root build script (--skip-nx-cache), and refresh pnpm-lock.yaml
  • Replace pinned internal versions with workspace:* across packages (e.g., analytics-*, plugin-*, session-replay-*, gtm-snippet, targeting, unified)
  • Add @aws-sdk/client-s3 as a dev dependency in the root and multiple packages used by publish scripts
  • Unified SDK: re-export setTransport directly from client and drop explicit type import; minor import tidy in analytics-core debug.ts

Written by Cursor Bugbot for commit 6fc0511. This will update automatically on new commits. Configure here.

@daniel-graham-amplitude daniel-graham-amplitude changed the title Amp 145286 use workspace chore: use workspaces Dec 29, 2025
@daniel-graham-amplitude daniel-graham-amplitude changed the base branch from AMP-145286-use-pnpm to pnpm-migration December 29, 2025 23:36
Copy link
Contributor

@Mercy811 Mercy811 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@daniel-graham-amplitude daniel-graham-amplitude merged commit 5ed0db2 into pnpm-migration Dec 30, 2025
10 of 11 checks passed
@daniel-graham-amplitude daniel-graham-amplitude deleted the AMP-145286-use-workspace branch December 30, 2025 23:10
@Mercy811
Copy link
Contributor

Synced offline. We merged this PR despite of the failed "Continuous Integration (Nx) / Check Deprecated Packages (pull_request)" as it's intended to update client-common

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants