Skip to content

Conversation

@daniel-graham-amplitude
Copy link
Collaborator

@daniel-graham-amplitude daniel-graham-amplitude commented Jan 2, 2026

Reverts #1460


Note

Reverts the publish-v2 workflow to use npm scripts instead of pnpm.

  • Switches all pnpm deploy:* invocations to npm run deploy:* across release, prerelease, and dry-run paths
  • Changes releaseType default to release
  • Adjusts version/publish flags (e.g., --create-release github, from-git, --pre-dist-tag beta, verbose logging) and removes the dry-run publish step
  • Prerelease flow now errors if no branch input is provided and passes --allow-branch/--preid accordingly
  • Minor step renames and log output tweaks in the version step

Written by Cursor Bugbot for commit 464afd3. This will update automatically on new commits. Configure here.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts a previous change that upgraded the publish-v2 workflow from npm to pnpm. The revert restores npm-based commands and removes some pnpm-specific enhancements.

Key changes:

  • Reverts all pnpm commands back to npm run equivalents across deployment and prerelease jobs
  • Changes the default release type from "prerelease" to "release"
  • Removes the dry-run publish step that was added in the pnpm upgrade

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@daniel-graham-amplitude daniel-graham-amplitude changed the title Revert "chore: upgrade publish-v2 workflow to use pnpm" chore: revert upgrade publish-v2 workflow to use pnpm Jan 2, 2026
@macroscopeapp
Copy link
Contributor

macroscopeapp bot commented Jan 2, 2026

Revert the publish-v2 GitHub Actions workflow to use npm run scripts and set the manual dispatch default inputs.releaseType to release in publish-v2.yml

Switch workflow steps from pnpm to npm run, change manual dispatch default to release, adjust version and publish flags for e2e and prerelease jobs, and remove the dry-run NPM publish step in publish-v2.yml.

📍Where to Start

Start in the e2e job steps of publish-v2.yml, focusing on Create release version and Publish Release to NPM.


Macroscope summarized 464afd3.

@daniel-graham-amplitude daniel-graham-amplitude merged commit 5322a76 into main Jan 3, 2026
10 checks passed
@daniel-graham-amplitude daniel-graham-amplitude deleted the revert-1460-pnpm-workflow branch January 3, 2026 01:21
- name: Publish Release to NPM
run: |
GH_TOKEN=${{ secrets.GH_PUBLISH_TOKEN }} pnpm deploy:publish --ignore-scripts
GH_TOKEN=${{ secrets.GH_PUBLISH_TOKEN }} npm run deploy:publish -- ${{ env.PUBLISH_FROM }} -y --pre-dist-tag beta --loglevel silly
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

${{ env.PUBLISH_FROM }} on line 123 is undefined in this workflow, so npm run deploy:publish receives an empty arg. Consider hard-coding from-git here (or define PUBLISH_FROM in env).

Suggested change
GH_TOKEN=${{ secrets.GH_PUBLISH_TOKEN }} npm run deploy:publish -- ${{ env.PUBLISH_FROM }} -y --pre-dist-tag beta --loglevel silly
GH_TOKEN=${{ secrets.GH_PUBLISH_TOKEN }} npm run deploy:publish -- from-git -y --pre-dist-tag beta --loglevel silly

🚀 Want me to fix this? Reply ex: "fix it for me".

- name: Publish Release to NPM
run: |
GH_TOKEN=${{ secrets.GH_PUBLISH_TOKEN }} pnpm deploy:publish --ignore-scripts
GH_TOKEN=${{ secrets.GH_PUBLISH_TOKEN }} npm run deploy:publish -- ${{ env.PUBLISH_FROM }} -y --pre-dist-tag beta --loglevel silly
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undefined PUBLISH_FROM environment variable in deploy command

The deploy:publish command references ${{ env.PUBLISH_FROM }} but this environment variable is never defined anywhere in the workflow. This will result in an empty string being passed to the npm command, likely causing the publish step to fail or behave unexpectedly during production releases. The prerelease job correctly uses from-git as a literal value on line 188, suggesting this should also be a literal value rather than an undefined variable.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants