-
Notifications
You must be signed in to change notification settings - Fork 58
chore: revert upgrade publish-v2 workflow to use pnpm #1461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 1ceb41a.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR reverts a previous change that upgraded the publish-v2 workflow from npm to pnpm. The revert restores npm-based commands and removes some pnpm-specific enhancements.
Key changes:
- Reverts all
pnpmcommands back tonpm runequivalents across deployment and prerelease jobs - Changes the default release type from "prerelease" to "release"
- Removes the dry-run publish step that was added in the pnpm upgrade
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Revert the publish-v2 GitHub Actions workflow to use
|
| - name: Publish Release to NPM | ||
| run: | | ||
| GH_TOKEN=${{ secrets.GH_PUBLISH_TOKEN }} pnpm deploy:publish --ignore-scripts | ||
| GH_TOKEN=${{ secrets.GH_PUBLISH_TOKEN }} npm run deploy:publish -- ${{ env.PUBLISH_FROM }} -y --pre-dist-tag beta --loglevel silly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
${{ env.PUBLISH_FROM }} on line 123 is undefined in this workflow, so npm run deploy:publish receives an empty arg. Consider hard-coding from-git here (or define PUBLISH_FROM in env).
| GH_TOKEN=${{ secrets.GH_PUBLISH_TOKEN }} npm run deploy:publish -- ${{ env.PUBLISH_FROM }} -y --pre-dist-tag beta --loglevel silly | |
| GH_TOKEN=${{ secrets.GH_PUBLISH_TOKEN }} npm run deploy:publish -- from-git -y --pre-dist-tag beta --loglevel silly |
🚀 Want me to fix this? Reply ex: "fix it for me".
| - name: Publish Release to NPM | ||
| run: | | ||
| GH_TOKEN=${{ secrets.GH_PUBLISH_TOKEN }} pnpm deploy:publish --ignore-scripts | ||
| GH_TOKEN=${{ secrets.GH_PUBLISH_TOKEN }} npm run deploy:publish -- ${{ env.PUBLISH_FROM }} -y --pre-dist-tag beta --loglevel silly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Undefined PUBLISH_FROM environment variable in deploy command
The deploy:publish command references ${{ env.PUBLISH_FROM }} but this environment variable is never defined anywhere in the workflow. This will result in an empty string being passed to the npm command, likely causing the publish step to fail or behave unexpectedly during production releases. The prerelease job correctly uses from-git as a literal value on line 188, suggesting this should also be a literal value rather than an undefined variable.
Reverts #1460
Note
Reverts the
publish-v2workflow to usenpmscripts instead ofpnpm.pnpm deploy:*invocations tonpm run deploy:*across release, prerelease, and dry-run pathsreleaseTypedefault torelease--create-release github,from-git,--pre-dist-tag beta, verbose logging) and removes the dry-run publish stepbranchinput is provided and passes--allow-branch/--preidaccordinglyWritten by Cursor Bugbot for commit 464afd3. This will update automatically on new commits. Configure here.