feat: provide setting to use only non-cellular, inexpensive and non-constrained network for sending logged events to Amplitude servers #347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om using cellular and other expensive or constrainted network (personal hotspot, low data network)
Contributor
|
Very awesome PR and callout @junjie . Sending data over networks efficiently is really important for best practices in mobile SDKs. Getting our engineers to take a look. |
… existing property as per documented behavior amplitude#387
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the option
setSendOverInexpensiveNetworkOnly:toAmplitude. When enabled, the SDK will only be able to use WiFi and other inexpensive networks as determined by iOS/macOS to send logged events to server.Checklist