-
Notifications
You must be signed in to change notification settings - Fork 13
Clarify difference between flag prerequisites and user property targe… #1281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ting Adds a new section comparing flag prerequisites with targeting based on [Experiment] user properties. Explains timing considerations, dependency tracking, and provides a table of when to use each approach. Resolves DOC-419
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment @cursor review or bugbot run to trigger another review on this PR
|
|
||
| **Limitations:** | ||
|
|
||
| - **Timing issues**: The `[Experiment]` user property is set when the assignment or exposure event is ingested. If you evaluate a dependent flag before this property syncs, the user may not match the targeting rule. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Passive voice in timing issues explanation (Bugbot Rules)
The sentence "The [Experiment] user property is set when the assignment or exposure event is ingested" uses passive voice ("is set", "is ingested"). Active voice would be clearer, such as "Amplitude sets the [Experiment] user property when it ingests the assignment or exposure event."
|
|
||
| **Advantages:** | ||
|
|
||
| - **Evaluated together**: Prerequisites are evaluated in sequence during a single evaluation call, eliminating timing issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Passive voice in evaluated together bullet point (Bugbot Rules)
The sentence "Prerequisites are evaluated in sequence during a single evaluation call" uses passive voice ("are evaluated"). Active voice would be clearer, such as "Amplitude evaluates prerequisites in sequence during a single evaluation call."
|
|
||
| | Use case | Recommended approach | | ||
| |----------|---------------------| | ||
| | Users must be assigned to Flag-A before seeing Flag-B | Flag prerequisites | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Passive voice in table use cases (Bugbot Rules)
The table contains passive voice constructions: "Users must be assigned to Flag-A" (line 95) and "users who were exposed to a flag" (line 98). Consider active alternatives like "Assign users to Flag-A before they see Flag-B" and "Target users you exposed to a flag days or weeks ago."
Additional Locations (1)
|
|
||
| When Amplitude assigns a user to a flag or experiment variant, it sets a user property in the format `[Experiment] <flag_key>` with the variant key as the value. You can use this user property in another flag's targeting rules to target users based on their previous assignments. | ||
|
|
||
| **Example:** Target users where `[Experiment] Flag-A` equals `on`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Formatting in these sections are kind of weird. Lots of bold text and lists
emetelka1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
05d00f6 to
1461597
Compare
1461597
…ting
Adds a new section comparing flag prerequisites with targeting based on [Experiment] user properties. Explains timing considerations, dependency tracking, and provides a table of when to use each approach.
Resolves DOC-419
Note
Adds a concise comparison between flag prerequisites and targeting via
[Experiment]user properties, outlining trade-offs and when to use each.content/collections/advanced-techniques/en/flag-prerequisites.md):[Experiment]user properties in targeting with limitations (timing, lack of dependency visibility, potential inconsistency).Written by Cursor Bugbot for commit 1461597. This will update automatically on new commits. Configure here.