FOO-2877 Basic Card Embed updates #1291
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| | After element | Places the card immediately after the target element. | | ||
| | Replace element | Replaces the target element with the card. | | ||
|
|
||
| Click the three dot menu to access format settings. |
There was a problem hiding this comment.
Bug: UI element "three dot menu" missing bold formatting (Bugbot Rules)
The UI element "three dot menu" isn't bolded. According to the style guide, buttons, tabs, and fields require bold formatting. This text refers to a specific menu element in the interface and the style guide specifies using bold for such elements (for example, Save, Settings). The text "three dot menu" in line 159 needs to be formatted as three dot menu.
| | Pins | Controls position of the pin relative to the target element. Select the position and the alignment of the guide. For example, Position: `Bottom of target` and Alignment: `Left` places the guide below the target element, and aligns the guide's left side with the target's left side. | | ||
| | Tooltip | Specify the side of the target element that the info marker appears. Add additional vertical or horizontal offset as necessary. | | ||
| | Banner | Top or bottom of the page. Set the **Sticky** option to keep the banner visible while the user scrolls. Choose the Display style: **Inline** to display the banner within the contents of the page, or **Overlay** to float the banner on top of the page contents. | | ||
| | Card embed <br/> {.tag .web .zero} | Controls position relative to the target element. Select from Append, Prepend, Before, After, or Replace. Configure Width (Auto, Fixed, or Full), Alignment (Left, Center, Right) when width isn't Full, and Height (Auto, Fixed, or Full). | |
There was a problem hiding this comment.
Bug: Inconsistent bold formatting for UI option values (Bugbot Rules)
The Card embed row in the Position table uses plain text for option values like "Append, Prepend, Before, After, or Replace" and "(Auto, Fixed, or Full)", but lines 163-165 in the same document bold these same values as Auto, Fixed, Full, Left, Center, and Right. This creates an inconsistent formatting pattern within the same PR where identical option names are formatted differently.
| | Pins | Controls position of the pin relative to the target element. Select the position and the alignment of the guide. For example, Position: `Bottom of target` and Alignment: `Left` places the guide below the target element, and aligns the guide's left side with the target's left side. | | ||
| | Tooltip | Specify the side of the target element that the info marker appears. Add additional vertical or horizontal offset as necessary. | | ||
| | Banner | Top or bottom of the page. Set the **Sticky** option to keep the banner visible while the user scrolls. Choose the Display style: **Inline** to display the banner within the contents of the page, or **Overlay** to float the banner on top of the page contents. | | ||
| | Card embed <br/> {.tag .web .zero} | Controls position relative to the target element. Select from Append, Prepend, Before, After, or Replace. Configure Width (Auto, Fixed, or Full), Alignment (Left, Center, Right) when width isn't Full, and Height (Auto, Fixed, or Full). | |
There was a problem hiding this comment.
Bug: Missing conjunction "or" in list of options (Bugbot Rules)
The list "(Left, Center, Right)" is missing the conjunction "or" before the final item. According to the style guide's grammar rules for lists of three or more items, this needs to include the conjunction with an Oxford comma. Compare with line 164 in the same document which correctly uses "Left, Center, or Right". The text in line 237 is inconsistent and grammatically incomplete.
matthew-beaty
changed the title
|
As mentioned in the slack comments, we should catagorically not be including content that isn't accessible for customers and should not be using the tech docs for marketing content. I think we should work with Brand management to create a blog post for the corpsite for this content and then, when the feature is ready for GA, bring this back into the documentation. |
FOO-2877
Basic updates to support Card Embeds feature. This feature is feature gated for now, so we may want to add a coming soon label or something.
Note
Add documentation for Card Embeds (placement options, format settings) and related CSS selectors; update form-factor count to six and element selector guidance.
content/collections/guides_and_surveys/en/form-factors.md):Card embedrow; minor punctuation tweaks.content/collections/guides_and_surveys/en/custom-css.md):.amplitude-engagement-card-containerto form factor containers..amplitude-engagement-card,.amplitude-engagement-card-content.Written by Cursor Bugbot for commit d3b4f3f. This will update automatically on new commits. Configure here.