-
Notifications
You must be signed in to change notification settings - Fork 13
Amp 145965 update streaming doc #1300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| * The **Select and filter events** section (for example, filtering where a derived property is not null) | ||
| * The **Select additional properties** section | ||
| * The **Map properties to destination** section (if applicable) | ||
| * **Select and filter events** - For example, filtering events where a derived property is not null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * **Lookup properties**: You can stream lookup properties by requesting access from Amplitude. Lookup properties map existing event or user properties to new properties using a CSV file upload, and can enrich already-ingested events at query time. | ||
| * Lookup property files with over 1000 rows won't display in the streaming setup. | ||
| * After saving a lookup property file, it can take up to 1 hour to populate into the streaming system. | ||
| * **Channel classifiers**: Streaming channel classifiers requires requesting access from Amplitude. Channels act like derived properties applied in real-time during queries, and are primarily used by marketers to define acquisition channels based on UTM and referrer data. By default, you can't select channel properties in sync configuration (event filters or additional properties) unless this feature is explicitly enabled for your organization. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passive voice introduced where active voice existed (Bugbot Rules)
The phrase "unless this feature is explicitly enabled for your organization" uses passive voice. The original text used active voice: "unless you've explicitly enabled this feature". This violates the Active Voice rule (highest priority in style guide). Consider rephrasing to maintain active voice, such as "unless Amplitude enables this feature for your organization" or "unless you have this feature enabled".
| * Custom events that don't meet the criteria in the [Supported custom events](#supported-custom-events) section. | ||
| * Group properties. | ||
| * Cart properties. | ||
| * Nested properties (for example, derived properties that rely on other derived properties). Exception: The UI allows selecting nested properties based on merged or cart properties, but these won't work in practice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Future tense used instead of present tense (Bugbot Rules)
The phrase "but these won't work in practice" uses future tense ("won't work"). The style guide requires present tense and flags "will" and "will not" constructions. This violates the Present Tense rule (high priority). The text can be changed to "but these don't work in practice" to use present tense.
Background
I did in 2 commits:
Claude Codeimproves on this doc.Let me know if they are good, or I can revert 2nd commit if needed.
Note
Refreshes the
streaming-transformations.mddoc for clarity and completeness.group/cart/nested properties), notes Data Warehouse exclusion, and details channel classifiers/lookup properties access and behaviorWritten by Cursor Bugbot for commit 442f5a6. This will update automatically on new commits. Configure here.