Decrease swipe sensitivity for hint overlay #12596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imorAnimationFixes
…imorAnimationFixes
…imorAnimationFixes
…essSensitiveSwipe
alanorozco
requested changes
Dec 22, 2017
| gestures.onGesture(SwipeXYRecognizer, e => { | ||
| const xSwipe = Math.abs(e.data.deltaX); | ||
| const ySwipe = Math.abs(e.data.deltaY); | ||
| const minSwipeDelta = 50; |
Member
There was a problem hiding this comment.
Should be a top-level-constant, MIN_SWIPE_FOR_HINT_OVERLAY_PX = 50.
| gestures.onGesture(SwipeXYRecognizer, () => { | ||
| if (this.bookend_.isActive()) { | ||
| gestures.onGesture(SwipeXYRecognizer, e => { | ||
| const xSwipe = Math.abs(e.data.deltaX); |
Member
There was a problem hiding this comment.
- Refactor into boolean method.
- Make short-circuit clauses independent.
if (this.bookend_.isActive()) {
return;
}
if (!isSwipeLargeEnoughForHint_(e.data.deltaX, e.data.deltaY)) {
return;
}| const xSwipe = Math.abs(e.data.deltaX); | ||
| const ySwipe = Math.abs(e.data.deltaY); | ||
| const minSwipeDelta = 50; | ||
| const canShowEducationOverlay = |
Member
There was a problem hiding this comment.
Avoid the word education as the current terminology is hint.
| const ySwipe = Math.abs(e.data.deltaY); | ||
| const minSwipeDelta = 50; | ||
| const canShowEducationOverlay = | ||
| xSwipe > minSwipeDelta || ySwipe > minSwipeDelta; |
Member
There was a problem hiding this comment.
This is inaccurate, you should calculate line distance:
Math.sqrt(Math.pow(deltaX, 2) + Math.pow(deltaY, 2))
> MIN_SWIPE_FOR_HINT_OVERLAY_PX
Member
Author
There was a problem hiding this comment.
oh yeah... makes sense
alanorozco
changed the title
alanorozco
changed the title
alanorozco
approved these changes
Jan 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a threshold to swipe before education system is triggered