Merged
Conversation
Collaborator
Author
|
This fixes level 0, but not the rest (openphi vs libisyntax):
Note level_padding is 1533 in this case. |
Member
|
Can I merge this, or should we wait until it's fixed for all the levels beside level 0? |
Collaborator
Author
|
@Falcury I would fix it in level 0, the other levels are no proper power of 2, and I can’t figure out any formula that generates these values. These 2-3 pixels are also not an issue because of the minimal padding, so I don’t think it will ever be out of bounds. So I would consider the current one ‘correct’ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the height/width computation. See #20. Also matches python implementation.