This repository was archived by the owner on Apr 30, 2021. It is now read-only.
Pin PyYAML==3.13 and fix unit tests#37
Merged
Merged
Conversation
PyYAML>=5.1 introduces a backwards-incompatible change with regards to the YAML parser. Until this package is made compatible, just stick with the old version. See https://msg.pyyaml.org/load
The parser outputs OrderedDict instances. Tests were not fixed after this change :o
an2deg
approved these changes
Apr 30, 2019
Owner
an2deg
left a comment
an2deg
left a comment
There was a problem hiding this comment.
Looks good for me. I'm gonna merge it
|
Hi @mzagozen, @an2deg Do you have any plans to update to latest pyyaml? We started getting this warning on github with older pyyaml version https://nvd.nist.gov/vuln/detail/CVE-2017-18342 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a new version of PyYAML 5.1 released in March: https://lists.gt.net/python/python/1413898.
This package requires
PyYAML>=3.10, so any new installations will pull the new version. But, the new version has a backwards incompatible change to theyaml.load()function. See https://msg.pyyaml.org/load.The change breaks the
!includetag parsing for this package. The functionality in PyYAML is still evolving and will change for the better in 5.2 (see yaml/pyyaml#279). Thus I would rather wait with >=5.1 compatibility fixes until 5.2.In this branch, I pinned PyYAML to last working 3.13 working version. Additionally, I fixed the unit tests that were failing.
@an2deg please activate the project in Travis: https://travis-ci.org/an2deg/pyraml-parser. Only the repo admin can do that.