-
Notifications
You must be signed in to change notification settings - Fork 11
Description
Hi @anDoer,
Thank you for adapting the HOTA for keypoint tracking. I would like to bring to your notice about possible error in computing the False positives in images where there is no GT.
In line
| res['HOTA_FP'][a] += num_tracker_joints |
the FP are added by variable
num_tracker_joints .
However the variable num_tracker_joints is a vector of size (J,) containing number of all valid keypoints in entire video (which is huge value for long-sequence videos) and not just the detections in current frame.
Please see
| num_tracker_joints += count_valid_joints(tracker_dets) |
In other words, the FP at time instant t is added by incorrect value and I observed HOTA significantly degrades by few frames (near the end of video) with no GT annotation
I think it should be modified to res['HOTA_FP'][a] += len(tracker_ids_t).
Furthermore, same analogy for FNs in the later lines with zero predictions. res['HOTA_FN'][a] += num_gt_joints to be modified to res['HOTA_FN'][a] += len(gt_ids_t ).
Please correct me if I'm wrong