Add test functions to test new unify function #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@anaradanovic Hi Ana! Let's hold off on merging this until we can chat more tomorrow :) |
Author
|
Ok, pytest is passing!!! |
drammock
reviewed
Sep 27, 2023
Comment on lines
8
to
16
| @pytest.mark.parametrize( | ||
| "instance", ("raw", "epochs", "evoked", "raw_spectrum", "epochs_spectrum") | ||
| ) | ||
| def test_instance_support(instance, request, evoked): | ||
| """Tests support of different classes.""" | ||
| # test unify_bads function on instance (single input, no bads scenario) | ||
| inst = _get_inst(instance, request, evoked) | ||
| inst_out = unify_bad_channels([inst]) | ||
| assert inst_out == [inst] |
There was a problem hiding this comment.
can be removed, only need to test one instance type.
| m_out = unify_bad_channels([one_bad, no_bad, three_bad]) | ||
| assert len(m_out) == 3 | ||
| correct_bads = [chns[1], chns[0], chns[2]] | ||
| for i in np.arange(len(m_out)): |
There was a problem hiding this comment.
Suggested change
| for i in np.arange(len(m_out)): | |
| for i in range(len(m_out)): |
drammock
reviewed
Sep 27, 2023
Co-authored-by: Daniel McCloy <dan@mccloy.info>
Author
|
@anaradanovic Hi Ana! Ok, Dan thinks that we're ready to accept this PR. |
Author
|
Ok, now, actually for real we're ready to accept this PR! |
|
indeed! @anaradanovic please merge this one, then we'll do a final review/merge of the combined work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds test functions to test unify_bad_channels.