indexer tests: more tests! mostly about indexing perl #510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 12, 2024
Draft
wolfsage
reviewed
May 19, 2024
Collaborator
wolfsage
left a comment
wolfsage
left a comment
There was a problem hiding this comment.
A bunch of nits and questions, but seems good!
This commit has a spelling error: indexer tests: more converstion to assert_index_updated
converstion -> conversion
The previous method for checking this was generic, which is nice, but
sort of verbose to use. Worse, though, I don't think it was reliable.
That code, ->file_updated_ok and ->file_not_updated_ok, worked by
keeping a cache of file stats -- but it didn't precompute those stats,
it computed them on demand. So given this program:
$pause = PAUSE::TestPause->new;
do_stuff();
my $r1 = $pause->test_reindex;
do_other_stuff();
$pause->file_updated_ok("A");
my $r2 = $pause->test_reindex;
do_more_stuff();
my $r3 = $pause->test_reindex;
Calling `->file_updated_ok("A")` at the end would test since the
previous call. Calling `->file_updated_ok("B")` at the end would test
starting from nothing.
In reality, we only use this method for tracking 02packages, so I've
added specific tracking of that file, with the check put onto the Result
object, considering only what changed in the `test_reindex` call that
created that Result.
(I want to test files we can't extract.)
...and add methods to check or print them.
(Specificaly: it is perl-like, not unauthorized real perl.)
That is: a new relase of perl-5, even if it contains a higher version of some dual-life package, should not replace the old package in the index, if it comes from a non-perl distribution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't just add tests, it adds some nice little helpers for writing tests. I'm writing these tests to benefit the PAUSE::Indexer::Context branch.