add more DPT's to decoder #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticroentgen
commented
Sep 30, 2016
elasticroentgen
commented
- add DPT13/DPT14
- fix DPT1
- don't let unkown formats pass as DPT1 they will now result in 'UNKN'
- add DPT13/DPT14 - fix DPT1 - don't let unkown formats pass as DPT1 they will now result in 'UNKN'
Owner
|
Could you please fix the test? |
Author
|
Fixed. I don't have tests yet for the new DPT's. When i find some time i'll add some later. |
Owner
|
Hello @thereapman, I've merged the UNKN datatype. I merged the changes from @stasee in #39. This means I decided to remove the assumptions about DPT13/14 in decoder, too. I don't feel save to add more assumptions about package length and datatypes. Are you sure that DPT13/14 are the only datatypes that could have this package length? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.