New parameter with sendAPDU #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
third parameter doNotCloseConnection {Boolean} allows client program to
send multiple telegrams using the same connection.
See #43
Additionally: formatting, commenting (JSDoc) for functions
Contributor
Author
|
This should pin the physical KNX address with latest knxd as discussed in knxd/knxd#190 (comment) |
Owner
|
I don't like 4 space indention in node/js. Could you revert this change? I tried to follow this guide. |
Contributor
Author
|
Of course. |
Contributor
Author
|
Ok, already fixed that one: http://nodeguide.com/style.html#variable-declarations |
set to http://nodeguide.com/style.html settings, espc indentation 2 spc instead of TAB
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
third parameter doNotCloseConnection {Boolean} allows client program to
send multiple telegrams using the same connection.
See #43
Additionally: formatting, commenting (JSDoc) for functions