feat(lint): add UncheckedFlagAccess detector (#157)#177
Closed
kirich1409 wants to merge 1 commit intomainfrom
Closed
feat(lint): add UncheckedFlagAccess detector (#157)#177kirich1409 wants to merge 1 commit intomainfrom
kirich1409 wants to merge 1 commit intomainfrom
Conversation
Detects calls to @BehindFlag-annotated functions that are not guarded by a valid flag context (if/when referencing the flag by name, or enclosing function annotated with the same @BehindFlag). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one. |
Contributor
Author
|
Closing: content merged in #176. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UncheckedFlagAccessDetector— an Android Lint rule (WARNING, priority 8) that flags calls to@BehindFlag("flagName")-annotated functions when the call site is not inside a valid guard contextif/whenexpression referencing the flag by name, or an enclosing function annotated with the same@BehindFlagFeaturedIssueRegistryImplementation notes
@BehindFlaghasSOURCEretention, so annotations are read via PSI (PsiAnnotation) rather than descriptors;ConstantEvaluator.evaluate()is used to resolve string values from Kotlin sourcesUSwitchClauseExpression.caseValuesis checked in addition toUSwitchExpression.expressionto handle bothwhen (flag) { ... }(subject form) andwhen { flag -> ... }(conditionless form), including lint'sTestMode.IF_TO_WHENrewriteTest plan
expectWarningCount(1)if (flag)guard,@BehindFlagenclosing function, no annotation,when (flag)subject — allexpectClean():featured-lint-rules:testpassCloses #157
🤖 Generated with Claude Code