Skip to content

feat(platform): use JavaPreferencesConfigValueProvider on JVM #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kirich1409 merged 1 commit into from
Apr 29, 2026
Merged

feat(platform): use JavaPreferencesConfigValueProvider on JVM #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions featured-platform/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,10 @@ kotlin {
iosMain.dependencies {
implementation(project(":providers:nsuserdefaults"))
}

jvmMain.dependencies {
implementation(project(":providers:javaprefs"))
}
}
}

Expand Down
2 changes: 1 addition & 1 deletion ...form/src/commonMain/kotlin/dev/androidbroadcast/featured/platform/DefaultLocalProvider.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import dev.androidbroadcast.featured.LocalConfigValueProvider
* | Platform | Implementation |
* |----------|----------------|
* | iOS | [dev.androidbroadcast.featured.nsuserdefaults.NSUserDefaultsConfigValueProvider] |
* | JVM | [dev.androidbroadcast.featured.InMemoryConfigValueProvider] (persistent provider pending #66) |
* | JVM | [dev.androidbroadcast.featured.javaprefs.JavaPreferencesConfigValueProvider] |
* | Android | [dev.androidbroadcast.featured.InMemoryConfigValueProvider] (non-persistent, deprecated) |
*
* **Android note:** On Android this overload is deprecated and returns a non-persistent
Expand Down
13 changes: 3 additions & 10 deletions ...latform/src/jvmMain/kotlin/dev/androidbroadcast/featured/platform/DefaultLocalProvider.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,9 @@
package dev.androidbroadcast.featured.platform

import dev.androidbroadcast.featured.InMemoryConfigValueProvider
import dev.androidbroadcast.featured.LocalConfigValueProvider

// TODO(#66): Replace with JavaPreferencesConfigValueProvider once available.
import dev.androidbroadcast.featured.javaprefs.JavaPreferencesConfigValueProvider

/**
* Returns an [InMemoryConfigValueProvider] on JVM.
*
* A persistent JVM provider (Java Preferences-backed) is tracked in issue #66.
* Until that module ships, this returns an in-memory provider so integrators can
* adopt the `defaultLocalProvider()` call site today and benefit from persistence
* automatically once #66 lands.
* Returns a [JavaPreferencesConfigValueProvider] on JVM (persists via `java.util.prefs.Preferences`).
*/
public actual fun defaultLocalProvider(): LocalConfigValueProvider = InMemoryConfigValueProvider()
public actual fun defaultLocalProvider(): LocalConfigValueProvider = JavaPreferencesConfigValueProvider()
Loading