Add :sample:android-app standalone Android application module#180
Merged
kirich1409 merged 4 commits intomainfrom Apr 30, 2026
Merged
Add :sample:android-app standalone Android application module#180kirich1409 merged 4 commits intomainfrom
kirich1409 merged 4 commits intomainfrom
Conversation
Creates a new :sample:android-app module (com.android.application) that depends on :sample, :featured-debug-ui, and :featured-platform. Wires DataStoreConfigValueProvider via defaultLocalProvider(context) and shows FeatureFlagsDebugScreen on demand. Also populates :sample's androidMain manifest and MainActivity so the existing KMP sample module can run as a self-contained Android activity. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one. |
- Delete accidental MainActivity from :sample KMP library module - Revert :sample androidMain manifest to empty (library must not declare launcher Activity) - Remove androidMain deps block from :sample (belonged to deleted MainActivity) - Remove featured-debug-ui from :sample commonMain (only needed in android-app) - android-app: fix import order for BackHandler - android-app: use applicationContext instead of this for defaultLocalProvider - android-app: add shrinkResources = true alongside isMinifyEnabled - android-app: add androidx.appcompat for Theme.AppCompat.Light.NoActionBar - android-app: remove tools:replace (library manifest no longer declares theme)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:sample:android-app(com.android.application) as a standalone Android sample appDataStoreConfigValueProviderviadefaultLocalProvider(context)from:featured-platformFeatureFlagsDebugScreenon demand via button inSampleApp:sample's androidMainAndroidManifest.xmlandMainActivityso the KMP module's existing Android target also worksHow to build
APK:
sample/android-app/build/outputs/apk/release/Notes
google-services.json)consumerProguardFilesConfigValuesis scoped to Activity for simplicity; in production use Application/DI singleton to avoid DataStore file conflicts across rotationsCloses #171
🤖 Generated with Claude Code