Wire lint detectors into core AAR via lintPublish#181
Open
kirich1409 wants to merge 1 commit intomainfrom
Open
Wire lint detectors into core AAR via lintPublish#181kirich1409 wants to merge 1 commit intomainfrom
kirich1409 wants to merge 1 commit intomainfrom
Conversation
Without this, lint detectors (UncheckedFlagAccess, ExpiredFeatureFlag,
InvalidFlagReference, HardcodedFlagValue) were published as a separate
artifact but never activated automatically in consumer projects.
- core/build.gradle.kts: add lintPublish(project(":featured-lint-rules"))
with isTransitive=false so AGP sees exactly one JAR (kotlin-stdlib is
provided by the lint host at runtime)
- sample/android-app/build.gradle.kts: add compileOptions JVM 21 to
match upstream modules and avoid inline-bytecode mismatch errors
Verified: lint.jar embedded in core.aar; HardcodedFlagValue detector
fires on consumer code via :sample:android-app:lintRelease.
ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without
lintPublish, the four lint detectors (#157, #158, #159 + existing HardcodedFlagValue) were published as a separate artifact but never activated automatically in Android Studio — users would have to addfeatured-lint-rulesmanually.Changes
core/build.gradle.ktslintPublish(project(":featured-lint-rules"))so the lint JAR is embedded infeatured-core.aarisTransitive = falseon thelintPublishconfiguration —kotlin-stdlibis provided by the lint host at runtime; without this AGP fails with "Found more than one jar in lintPublish"sample/android-app/build.gradle.ktscompileOptions { sourceCompatibility/targetCompatibility = VERSION_21 }to match upstream modules (core, platform, etc. all compile to JVM 21); without this, Kotlin inline functions from JVM-21-compiled deps cause a compile errorVerification
Closes #— (no issue, discovered during v1.0.0 pre-release verification)