Skip to content

Refactoring 1#5

Merged
androidmage merged 2 commits intoandroidmage:masterfrom
jherd23:patch-2
Jan 6, 2016
Merged

Refactoring 1#5
androidmage merged 2 commits intoandroidmage:masterfrom
jherd23:patch-2

Conversation

@jherd23
Copy link
Copy Markdown
Contributor

@jherd23 jherd23 commented Jan 6, 2016

*Moved scanArchonLocation() to RESOURCE_FUNCTIONS for semantic reasons
*Made scanArchonLocation() static so it can be accessed by any inner class and any member of RESOURCE_FUNCTIONS
*Changed scanArchonLocation() to return null if no Archon is found
-Removed Scout.scanArchon() as its functionality is found in RESOURCE_FUNCTIONS.scanArchonLocation() [ie: if it returns null, same as returning false in the prior, if not null, same as true]
-Removed 1 line of white space at bottom
+Commented RESOURCE_FUNCTIONS.scanArchonLocation()
+Added comments for new Global Variables
+Added new function: RESOURCE_FUNCTIONS.trySendMessage()
+takes 56 bits of data (over Tuple of ints), a key for encryption, and a type, and constructs the pair of ints that need to be sent to show said information. I will add decryption method very soon

*Moved scanArchonLocation() to RESOURCE_FUNCTIONS for semantic reasons
*Made scanArchonLocation() static so it can be accessed by any inner class and any member of RESOURCE_FUNCTIONS
*Changed scanArchonLocation() to return null if no Archon is found
-Removed Scout.scanArchon() as its functionality is found in RESOURCE_FUNCTIONS.scanArchonLocation() [ie: if it returns null, same as returning false in the prior, if not null, same as true]
+Commented RESOURCE_FUNCTIONS.scanArchonLocation()
+New, encrypted RESOURCE_FUNCTIONS.trySendMessage function
androidmage added a commit that referenced this pull request Jan 6, 2016
@androidmage androidmage merged commit 4b58036 into androidmage:master Jan 6, 2016
@jherd23 jherd23 deleted the patch-2 branch January 6, 2016 15:32
androidmage pushed a commit that referenced this pull request Jan 7, 2016
Merge pull request #10 from Soupdoop/master
androidmage pushed a commit that referenced this pull request Jan 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants