Carousel helper infinite in MotionLayout by Rodrigo Dominguez by rodrigomartind · Pull Request #39 · androidx/constraintlayout

rodrigomartind · 2020-11-30T13:31:45Z

I add a new attribute to configure the infinite carousel.
app:carousel_infinite="true"
With this attribute, transition backwardTransition and forwardTransition are enabled always.
The iteration of the items is given in the same way as the following sequence: [1, 2, 3, 4, 5, 1, 2, 3, 4, 5].

Demos

Demo name	Normal	Infinite
Demo 010 carousel
Demo 020 carousel
Demo 030 carousel
Demo 040 carousel
Demo 060 carousel
Demo colors carousel

google-cla · 2020-11-30T13:31:56Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

rodrigomartind · 2020-11-30T13:48:22Z

@googlebot I signed it!

google-cla · 2020-11-30T13:48:27Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2020-11-30T13:48:31Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

rodrigomartind · 2020-11-30T13:49:59Z

@googlebot I fixed it

google-cla · 2020-11-30T13:50:04Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla · 2020-11-30T13:51:58Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

rodrigomartindMeli · 2020-11-30T13:52:02Z

@googlebot I consent

camaelon · 2020-11-30T17:40:07Z

...tlayout/constraintlayout/src/main/java/androidx/constraintlayout/helper/widget/Carousel.java

            int index = mIndex + i - startIndex;
            if (index < 0) {
-                updateViewVisibility(view, emptyViewBehavior);
+                if (infiniteCarousel) {


instead of this -- would it be simpler to check if infiniteCarousel is true and then compute index as the modulo of the count? then the bulk of the code would stay the same

Great, refactoring done.

camaelon · 2020-11-30T17:40:45Z

...xperiments/app/src/main/java/androidx/constraintlayout/experiments/CarouselHelperActivity.kt

@@ -0,0 +1,49 @@
+package androidx.constraintlayout.experiments


(c) notice missing

camaelon · 2020-11-30T17:41:44Z

projects/CarouselExperiments/app/src/main/res/layout/demo_010_carousel.xml

        app:carousel_backwardTransition="@+id/backward"
        app:carousel_previousState="@+id/previous"
        app:carousel_nextState="@+id/next"
+        app:carousel_infinite="true"


we probably don't want to have all examples using infinite?

I have left four infinite examples, and three normals.

camaelon · 2020-11-30T17:46:32Z

...ects/CarouselExperiments/app/src/main/java/androidx/constraintlayout/experiments/Loader.java

+        button.setOnClickListener(v -> {
+            Intent intent = new Intent(mainActivity, CarouselHelperActivity.class);
+            mainActivity.startActivity(intent);
+        });


Might be worth instead to modify the Loader.normalMenuStartUp to get an array of activity classes as a parameter instead, and then add them? Something around those lines, so that next demo that wants to be a separate activity would be easy to add.

Refactoring done, in MainActivity you can load the activity classes with examples activitiesDemo

camaelon · 2020-11-30T21:41:14Z

...tlayout/constraintlayout/src/main/java/androidx/constraintlayout/helper/widget/Carousel.java

@@ -143,13 +149,24 @@ public void onTransitionCompleted(MotionLayout motionLayout, int currentId) {
            mIndex--;
            System.out.println("decrement index...");


while here, can you remove the printfs? :)

camaelon · 2020-11-30T21:41:30Z

...tlayout/constraintlayout/src/main/java/androidx/constraintlayout/helper/widget/Carousel.java

+        if (infiniteCarousel) {
+            if (mIndex >= mAdapter.count()) {
+                mIndex = 0;
+                System.out.println("index capped... " + mIndex);


same thing, we can remove those printfs

camaelon · 2020-11-30T21:43:19Z

...tlayout/constraintlayout/src/main/java/androidx/constraintlayout/helper/widget/Carousel.java

@@ -309,17 +360,19 @@ private void updateItems() {
        }

        final int count = mAdapter.count();


can move the count variable inside the if block, or maybe simpler, add if (infiniteCarousel) { return; } before final int count

camaelon · 2020-11-30T21:50:54Z

...tlayout/constraintlayout/src/main/java/androidx/constraintlayout/helper/widget/Carousel.java

-                updateViewVisibility(view, emptyViewBehavior);
-            } else if (index >= mAdapter.count()) {
-                updateViewVisibility(view, emptyViewBehavior);
+            if (infiniteCarousel) {


oh what I meant was more something like:
if (infiniteCarousel) {
index = index % mAdapter.count();
}

but that's fine.

rodrigomartindMeli added 5 commits November 29, 2020 18:15

Carousel helper infinite

0975e42

Resolve infinte carousel firstItem

94c49cd

Resolve 0 items in adapter

7aeec7f

demo 50 & demo 60 with infinite carousel

db31d5a

Added demo from infinite carousel.

f3c5a0d

rodrigomartind closed this Nov 30, 2020

rodrigomartind reopened this Nov 30, 2020

camaelon reviewed Nov 30, 2020

View reviewed changes

Resolve PR

ce3aa86

camaelon reviewed Nov 30, 2020

View reviewed changes

Resolve PR comments

6ead59a

camaelon approved these changes Dec 1, 2020

View reviewed changes

camaelon merged commit f10ce02 into androidx:main Dec 1, 2020

		@@ -0,0 +1,49 @@
		package androidx.constraintlayout.experiments

		@@ -143,13 +149,24 @@ public void onTransitionCompleted(MotionLayout motionLayout, int currentId) {
		mIndex--;
		System.out.println("decrement index...");

		@@ -309,17 +360,19 @@ private void updateItems() {
		}

		final int count = mAdapter.count();

Conversation

rodrigomartind commented Nov 30, 2020

Demos

Uh oh!

google-cla bot commented Nov 30, 2020

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

rodrigomartind commented Nov 30, 2020

Uh oh!

google-cla bot commented Nov 30, 2020

Uh oh!

google-cla bot commented Nov 30, 2020

Uh oh!

rodrigomartind commented Nov 30, 2020

Uh oh!

google-cla bot commented Nov 30, 2020

Uh oh!

google-cla bot commented Nov 30, 2020

Uh oh!

rodrigomartindMeli commented Nov 30, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rodrigomartind Nov 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

rodrigomartind Nov 30, 2020 •

edited

Loading