Conversation
Replaces the SwiftUI Settings scene with an AppDelegate-owned NSWindowController so Settings stays reachable via Spotlight/Finder re-launch when the menu bar icon is hidden. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@AppStoragetoMenuBarExtra(isInserted:)Settingsscene with an AppDelegate-ownedSettingsWindowController(NSWindow + NSToolbar) so Settings stays reachable when the icon is hidden — re-launching from Spotlight/Finder routes throughapplicationShouldHandleReopenSettingsViewswitches onnav.selectedTabinstead of usingTabView, since the toolbar drives selectionTest plan
just dev— Settings opens from the menu, toolbar tabs switch correctly🤖 Generated with Claude Code