Use new jadx API for icons and usage dialog #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
This works great, thanks for implementing those new APIs and adding them here for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented new API methods to get jadx icons and open usage dialog.
Hope I correctly get a gui context in tree nodes, not sure for what cases parent can be null, please verify this 🙂
Also, these changes will work only for unstable jadx version (from here), but even if you release it right now, latest stable version of jadx (1.5.1) should skip incompatible release and install previous one (thanks to
.requiredJadxVersion("1.5.2, r2372")part in plugin info).