Skip to content

Fix isAbsoluteURL() regex#286

Closed
andywer wants to merge 1 commit intomasterfrom
bugfix/284-fix-absolute-url-regex
Closed

Fix isAbsoluteURL() regex#286
andywer wants to merge 1 commit intomasterfrom
bugfix/284-fix-absolute-url-regex

Conversation

@andywer
Copy link
Copy Markdown
Owner

@andywer andywer commented Aug 3, 2020

Fixes #284.

@andywer
Copy link
Copy Markdown
Owner Author

andywer commented Aug 3, 2020

@aminya I think I found the reason for the issue you ran into. It's just a one-liner. Can you monkey-patch the file in your local node_modules/ and check that it works?

@aminya
Copy link
Copy Markdown
Contributor

aminya commented Aug 3, 2020

Thank you! This does not solve the issue yet. I did not notice any difference. In implementation.browser.js, the code goes into the second if-else condition and this is the output of console.log(url) in both cases:

blob:file:///9f11280b-ad46-4df7-af45-97663a4a4abf

@aminya
Copy link
Copy Markdown
Contributor

aminya commented Aug 3, 2020

Check the pull request I made here: #287
Now the output URL is this:

file:///C:/Users/myproject/ide-json/lib/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refused to create a worker

2 participants