Adding param to environment.ts fails during unit tests

[francisoud]

I tried to add my backend url to environment.[dev|prod].ts as explain in README.md

src/environment.ts and config/environment.dev.ts (same content)

export const environment = {
  production: false,
  backend: {
    url: 'http://localhost:8080/api'
  }
};

config/environment.prod.ts

export const environment = {
  production: true,
  backend: {
    url: '/myapp/api'
  }
};

src/app/shared/profile-info.service.ts

import { Injectable }   from '@angular/core';
import { Http }         from '@angular/http';
import 'rxjs/add/operator/toPromise';
import { ProfileInfo }  from './profile-info.model';
import { environment }  from '../../app';

@Injectable()
export class ProfileInfoService {
  constructor(private http: Http) {}
  getProfileInfo(): Promise<ProfileInfo> {
    return this.http.get(environment.backend.url + '/profile-info')
               .toPromise()
               .then(response => response.json())
               .catch(this.handleError);
  }
  private handleError(error: any) {
    console.error('An error occurred', error);
    return Promise.reject(error.message || error);
  }
}

At runtime

ng serve or ng serve -prod works fine BUT...

Unit test fails

>ng test --watch false
Built project successfully. Stored in "dist/".
22 07 2016 14:32:55.601:INFO [karma]: Karma v0.13.22 server started at http://localhost:9876/
22 07 2016 14:32:55.612:INFO [launcher]: Starting browser PhantomJS
22 07 2016 14:32:57.102:INFO [PhantomJS 2.1.1 (Windows 7 0.0.0)]: Connected on socket /#oYsAdh6c6MnyuUvFAAAA with id 25522896
PhantomJS 2.1.1 (Windows 7 0.0.0) Contract Service should ... FAILED
        Error: Cannot resolve all parameters for 'AppComponent'(undefined). Make sure that all the parameters are decorated with Inject or have valid type annotations and that 'AppComponent' is decorated with Injectable. (line 233)
PhantomJS 2.1.1 (Windows 7 0.0.0) ProfileInfo Service should ... FAILED
        Error: Cannot resolve all parameters for 'AppComponent'(undefined). Make sure that all the parameters are decorated with Inject or have valid type annotations and that 'AppComponent' is decorated with Injectable. (line 233)
PhantomJS 2.1.1 (Windows 7 0.0.0) App: CromeFront should create the app FAILED
        Error: Cannot resolve all parameters for 'AppComponent'(undefined). Make sure that all the parameters are decorated with Inject or have valid type annotations and that 'AppComponent' is decorated with Injectable. (line 233)
PhantomJS 2.1.1 (Windows 7 0.0.0) App: CromeFront should have as title 'CROME' FAILED
        Error: Cannot resolve all parameters for 'AppComponent'(undefined). Make sure that all the parameters are decorated with Inject or have valid type annotations and that 'AppComponent' is decorated with Injectable. (line 233)
PhantomJS 2.1.1 (Windows 7 0.0.0): Executed 11 of 11 (4 FAILED) (0.021 secs / 0.022 secs)

What did I do wrong ?

Workaround

import { isDevMode } from '@angular/core';
...

@Injectable()
export class ProfileInfoService {
  private url: string;

  constructor(private http: Http) {}

  getProfileInfo(): Promise<ProfileInfo> {
    if(isDevMode()) {
      this.url = 'http://localhost:8080/api';
     } else {
       this.url = '/cromeApi/api';
    }
    return this.http.get(this.url + '/profile-info')
               .toPromise()
               .then(response => response.json())
               .catch(this.handleError);
  }
  private handleError(error: any) {
    console.error('An error occurred', error);
    return Promise.reject(error.message || error);
  }
}

Version

C:\tmp\myapp>ng --version
angular-cli: 1.0.0-beta.8
node: 6.2.1
os: win32 x64

[filipesilva]

Can you also show me your unit test?

[francisoud]

sure: src/app/shared/profile-info.service.spec.ts

/* tslint:disable:no-unused-variable */

import {
  beforeEach, beforeEachProviders,
  describe, xdescribe,
  expect, it, xit,
  async, inject
} from '@angular/core/testing';
import { ProfileInfoService } from './profile-info.service';

describe('ProfileInfo Service', () => {
  beforeEachProviders(() => [ProfileInfoService]);

  it('should ...',
      inject([ProfileInfoService], (service: ProfileInfoService) => {
    expect(service).toBeTruthy();
  }));
});

[filipesilva]

Sorry, I should have been more specific. Can you show me your failing ones?

[francisoud]

Actually this is one of failing ones:p
There's are default test generated by angular-cli
If I just add the environment values and use it in the service; the unit tests start fail ?!

[francisoud]

See error log:
PhantomJS 2.1.1 (Windows 7 0.0.0) ProfileInfo Service should ... FAILED
Error: Cannot resolve all parameters for 'AppComponent'(undefined).

[filipesilva]

Generally speaking, whenever you change in your classes the generated unit tests should immediately fail.

I think I see at least part of what's going wrong here... It's weird that your ProfileInfo test fails showing a message about AppComponent, right? And you say it happens only if you add import { environment } from '../../app';?

I know that ../../app also exports AppComponent, but have no idea how it gets inserted into your tests. If you can get me a repo that I can debug, I might be able to find you an answer.

[adamduren]

I am experiencing this same thing. The moment I try to use environment.foo within a service the component can no longer resolve the parameter for that service.

[adamduren]

Also the failure happens when I try to mock with provide(Api, { useValue: {} }). The moment I remove the line that references environment the tests start passing again.

[adamduren]

@filipesilva This is the bug reproduced from a angular-cli this happens on webpack-beta 1 and 2. Not sure about the broccoli version. It's making it impossible for us to test and deploy to production with confidence.

NorthernLogic/ng2-cli-environment-test-bug@5c8a1e2 (I got the bug reproduction wrong, forgot to add the service to the test, I'll submit a new one shortly.)

[adamduren]

Confirmed on the beta-10 as well. Oddly enough the app still compiles and runs. It seems to be specific to testing.

[adamduren]

Finally! So after almost driving myself crazy I believe I have gotten to the bottom of this. It has to do with the spec file import order. The commit posted below demonstrates the issue. The prior commit has a spec file test.service.spec.ts and I renamed that to api.service.spec.ts. Just doing that caused the tests to go from pass to fail. I then renamed it to app.service.spec.ts (so it would come after app.component.ts) and the tests started to pass again.

I'm not sure of the actual solution but at least I have a workaround for now.

NorthernLogic/ng2-cli-environment-test-bug@e02da5e

[filipesilva]

We're overhauling the app build process so I'm not sure this bug still exists. I you try the latest webpack release please? Instructions can be found here: https://github.com/angular/angular-cli#webpack-preview-release-update

Now that I think about it, there's no environment.ts replacement functionality in test builds overall... I think it should at least default to dev myself. I should add that.