docs: update stories featuring bootstrap#10122
docs: update stories featuring bootstrap#10122ahasall wants to merge 1 commit intoangular:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
|
I signed it! |
|
CLAs look good, thanks! |
| Using the `--save` option the dependency will be saved in package.json | ||
|
|
||
| ```sh | ||
| # version 3.x |
There was a problem hiding this comment.
Do we typically add instructions for adding old packages to projects? I'd suggest we remove the v.3 installation notes altogether.
There was a problem hiding this comment.
Yes. You are right. I updated the PR.
| @@ -12,7 +12,7 @@ First install Bootstrap from `npm`: | |||
| ```bash | |||
| npm install jquery --save | |||
| npm install popper.js --save | |||
There was a problem hiding this comment.
It's not something you added, but can we add that neither jquery nor popper.js are needed if you pretend to use only CSS? With the current docs people tend to feel that they have to install them obligatory.
There was a problem hiding this comment.
I totally agree with you. I will update my PR accordingly.
There was a problem hiding this comment.
I updated the PR. Tell me what you think about the changes.
|
@markgoho or @rafaelss95, |
|
Heya, this pr is superseded by #10541. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Bootstrap 4 has been released.
npm install bootstrap --saveinstalls Bootstrap 4 instead of Bootstrap 3.To install Boostrap 3, we should do
npm install bootsrap@3