Patching 1.3 branch with ng build breaking on uglify per 1.5 branch#11623
Patching 1.3 branch with ng build breaking on uglify per 1.5 branch#11623jellis wants to merge 1 commit intoangular:1.3.xfrom jellis:1.3.x
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
|
I've since signed the CLA - the breaking tests appear to be legacy issues (which this branch is likely to be the root cause of). |
|
CLAs look good, thanks! |
|
See #7931 for reference point. |
|
Hi @jellis, I'm sorry to say but version |
|
Such is life. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Whilst I'm aware we probably should be upgrading, we've got a lot of applications that are only being built with 1.3.x - until we're able to get through and test all the breakages, it'd be great if we could get this merged in (as it has been for some other branches/versions).