fix(@angular-devkit/build-angular): should not log duplicate messages

[Teamop]

Should not log duplicate messages for specFailure and onRunComplete, as they all have been handled by the baseReporter

[filipesilva]

Hi, can you give me some context about the problem you are fixing? A way for me to see it happening would be important as well.

[Teamop]

@filipesilva , yes it's for ng test, right now, all these reporters will log the same message twice, so here is just avoid the duplicate messages from these reporters, just leave to baseReporter to deal with them

[filipesilva]

I tried adding an error to an existing project, then introducing your changes, and I could still see duplicated error messages. Can you show me what do you see before and after your changes?

Edit: I noticed now that while there is still some duplication, it is less than before.

[filipesilva]

Can you change the commit message to fix(@angular-devkit/build-angular): should not log duplicate messages please? (build_angular -> build-angular)

[filipesilva]

This can be just this.specFailure = () => {};, and the same applies to the other ones.

[Teamop]

done, thanks

[Teamop]

hi @filipesilva, right now, with these changes, you will still see some duplicate, as these is also another reporter progress which comes from karma, and I have also submitted a PR karma-runner/karma#3080

[Teamop]

@filipesilva could you restart all the CI tests? seems all of them aren't triggered

[Teamop]

I will close and reopen to see if the CI can be restarted.

[filipesilva]

LGTM, thanks for this fix!

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}