Add support for Typescript 3.2#13226
Add support for Typescript 3.2#13226mgechev merged 5 commits intoangular:masterfrom alan-agius4:feat_typescript_3.2
Conversation
|
The 1Kb size change is due to the Angular 7.2 upgrade. |
clydin
left a comment
There was a problem hiding this comment.
Can you ensure that the two special cases in the isUsed call still work? (Exporting the alias and using the alias as an object literal shorthand). They both use the text of the node but the name node has the original name and not the alias name.
|
Actually we could probably clean that up some and grab the aliased symbol if present when looping through the file. |
|
@clydin I have added some more tests, can you check if that's the tests you had in mind? |
…ed with Typescript 3.2 When using the `specifier.propertyName` with `typeChecker.getSymbolAtLocation` it will return a more detailed symbol then we originally have in the `usedSymbols` set. We should probably use `symbol.id` to actually check if the symbols are the same, however the `id` is not exposed in the Symbol interface. Using `node.name` will return the same symbol that we have stored in the set. Fixes #13212
clydin
left a comment
There was a problem hiding this comment.
Actually, let's get this in and then followup with improved testing and a potential cleanup of the special cases.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Update to TypeScript 3.2
fix(@ngtools/webpack):
import asresults in the alias being undefined with Typescript 3.2When using the
specifier.propertyNamewithtypeChecker.getSymbolAtLocationit will return a more detailed symbol then we originally have in theusedSymbolsset.We should probably use
symbol.idto actually check if the symbols are the same, however theidis not exposed in the Symbol interface.Using
node.namewill return the same symbol that we have stored in the set.Fixes #13212