Pipe should implement PipeTransform interface#144
Closed
EmmanuelDemey wants to merge 2 commits intoangular:masterfrom
EmmanuelDemey:master
Closed
Pipe should implement PipeTransform interface#144EmmanuelDemey wants to merge 2 commits intoangular:masterfrom EmmanuelDemey:master
EmmanuelDemey wants to merge 2 commits intoangular:masterfrom
EmmanuelDemey:master
Conversation
Contributor
|
Tested and lgtm /cc @cironunes @Brocco |
Member
|
Needs to be rebased against current master, otherwise lgtm |
Member
|
Also, please make sure to follow the commit message guidelines |
clydin
pushed a commit
that referenced
this pull request
Jun 5, 2018
hansl
pushed a commit
that referenced
this pull request
Jun 6, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just add the PipeTransform interface that should be used when creating pipe