Skip to content

fix(@schematics/angular): polyfills migration leaving broken code in … #14448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mgechev merged 1 commit into from
May 17, 2019
Merged

fix(@schematics/angular): polyfills migration leaving broken code in … #14448

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions packages/schematics/angular/migrations/update-8/drop-es6-polyfills.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,12 +78,11 @@ function dropES2015PolyfillsFromFile(polyfillPath: string): Rule {
return;
}

// normalize line endings to increase hash match chances
const content = source.toString().replace(/\r\n|\r/g, '\n');

const content = source.toString();
// Check if file is unmodified, if so then replace and return
const hash = createHash('md5');
hash.update(content);
// normalize line endings to increase hash match chances
hash.update(content.replace(/\r\n|\r/g, '\n'));
const digest = hash.digest('hex');
if (knownPolyfillHashes.includes(digest)) {
// Replace with new project polyfills file
Expand Down