fix for #14467 - fix(@schematics/angular): webworker snippet should not generate to module by santoshyadavdev · Pull Request #14468 · angular/angular-cli

santoshyadavdev · 2019-05-19T13:43:36Z

Fixes #14467

alan-agius4 · 2019-05-20T07:27:59Z

@santoshyadav198613, thanks for this. Can you kindly fix the fixes in the commit message as well?
Thanks.

santoshyadavdev · 2019-05-20T07:32:06Z

Sure @alan-agius4 , will do thanks.

filipesilva

LGTM, thanks!

packages/schematics/angular/web-worker/index.ts

alan-agius4

See above.

…dule Fixes angular#14467

googlebot · 2019-05-21T06:08:53Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

alan-agius4

Hi @santoshyadav198613, sorry to barge in your PR and pushing directly. But we need to get this merged ASAP for the version 8 final.

Thanks a lot for your contribution.

//cc @alexeagle, this is a go!

alan-agius4 · 2019-05-21T06:10:28Z

packages/schematics/angular/web-worker/index_spec.ts

    inlineStyle: false,
    inlineTemplate: false,
-    routing: false,
+    routing: true,


Changing this value, will ensure that the improved logic is tested.

santoshyadavdev · 2019-05-21T06:59:42Z

Hi @santoshyadav198613, sorry to barge in your PR and pushing directly. But we need to get this merged ASAP for the version 8 final.

Thanks a lot for your contribution.

//cc @alexeagle, this is a go!

thanks @alan-agius4 , sorry was not feeling well, so was not able to make changes last night. But happy that I was able to find the issue.

googlebot · 2019-05-21T13:03:29Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

angular-automatic-lock-bot · 2019-09-13T02:42:43Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label May 19, 2019

santoshyadavdev force-pushed the fix(@schematics/angular)--web-worker-snippet-should-be-generated-to-component branch 2 times, most recently from 2765fb6 to 7d687fe Compare May 19, 2019 17:28

alan-agius4 requested a review from filipesilva May 20, 2019 07:25

filipesilva approved these changes May 20, 2019

View reviewed changes

filipesilva added the target: patch This PR is targeted for the next patch release label May 20, 2019

alan-agius4 reviewed May 20, 2019

View reviewed changes

packages/schematics/angular/web-worker/index.ts Outdated Show resolved Hide resolved

alan-agius4 added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label May 20, 2019

santoshyadavdev force-pushed the fix(@schematics/angular)--web-worker-snippet-should-be-generated-to-component branch 2 times, most recently from 118ef01 to 5f99db2 Compare May 20, 2019 14:02

santoshyadavdev changed the title ~~fix(@schematics/angular): webworker snippet should generate to component~~ fix(@schematics/angular): webworker snippet should not generate to module May 20, 2019

alan-agius4 reviewed May 20, 2019

View reviewed changes

packages/schematics/angular/web-worker/index.ts Outdated Show resolved Hide resolved

alan-agius4 requested changes May 20, 2019

View reviewed changes

alan-agius4 removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label May 20, 2019

IgorMinar added this to the 8.0 milestone May 20, 2019

IgorMinar changed the title ~~fix(@schematics/angular): webworker snippet should not generate to module~~ fix for #14467 fix(@schematics/angular): webworker snippet should not generate to module May 20, 2019

IgorMinar changed the title ~~fix for #14467 fix(@schematics/angular): webworker snippet should not generate to module~~ fix for #14467 - fix(@schematics/angular): webworker snippet should not generate to module May 20, 2019

santoshyadavdev and others added 2 commits May 21, 2019 08:02

fix(@schematics/angular): webworker snippet should not generate to mo…

a155cab

…dule Fixes angular#14467

refactor: update file filtering logic for webworker snippet Insertion

50ceb4d

alan-agius4 force-pushed the fix(@schematics/angular)--web-worker-snippet-should-be-generated-to-component branch from 5f99db2 to 50ceb4d Compare May 21, 2019 06:08

googlebot added cla: no and removed cla: yes labels May 21, 2019

alan-agius4 approved these changes May 21, 2019

View reviewed changes

alan-agius4 reviewed May 21, 2019

View reviewed changes

mgechev added cla: yes and removed cla: no labels May 21, 2019

mgechev merged commit 0d493cb into angular:master May 21, 2019

fareshan mentioned this pull request Jul 16, 2019

mime types are not set with version 8 #15094

Closed

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

fix for #14467 - fix(@schematics/angular): webworker snippet should not generate to module#14468

fix for #14467 - fix(@schematics/angular): webworker snippet should not generate to module#14468
mgechev merged 2 commits intoangular:masterfrom
santoshyadavdev:fix(@schematics/angular)--web-worker-snippet-should-be-generated-to-component

santoshyadavdev commented May 19, 2019 •

edited

Loading

Uh oh!

alan-agius4 commented May 20, 2019

Uh oh!

santoshyadavdev commented May 20, 2019

Uh oh!

filipesilva left a comment

Uh oh!

Uh oh!

Uh oh!

alan-agius4 left a comment

Uh oh!

googlebot commented May 21, 2019

Uh oh!

alan-agius4 left a comment

Uh oh!

alan-agius4 May 21, 2019 •

edited

Loading

Uh oh!

santoshyadavdev commented May 21, 2019

Uh oh!

googlebot commented May 21, 2019

Uh oh!

angular-automatic-lock-bot bot commented Sep 13, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Comments

Conversation

santoshyadavdev commented May 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alan-agius4 commented May 20, 2019

Uh oh!

santoshyadavdev commented May 20, 2019

Uh oh!

filipesilva left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

alan-agius4 left a comment

Choose a reason for hiding this comment

Uh oh!

googlebot commented May 21, 2019

Uh oh!

alan-agius4 left a comment

Choose a reason for hiding this comment

Uh oh!

alan-agius4 May 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

santoshyadavdev commented May 21, 2019

Uh oh!

googlebot commented May 21, 2019

Uh oh!

angular-automatic-lock-bot bot commented Sep 13, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

santoshyadavdev commented May 19, 2019 •

edited

Loading

alan-agius4 May 21, 2019 •

edited

Loading