fix(@ngtools/webpack): rebuilding project with errors reports cannot …#14658
Merged
alexeagle merged 1 commit intoangular:masterfrom Jun 6, 2019
alan-agius4:fix-error-on-first-build
Merged
fix(@ngtools/webpack): rebuilding project with errors reports cannot …#14658alexeagle merged 1 commit intoangular:masterfrom alan-agius4:fix-error-on-first-build
alexeagle merged 1 commit intoangular:masterfrom
alan-agius4:fix-error-on-first-build
Conversation
alan-agius4
added
target: patch
|
|
filipesilva
reviewed
Jun 4, 2019
filipesilva
approved these changes
Jun 4, 2019
packages/angular_devkit/build_angular/test/browser/rebuild_spec_large.ts
Outdated
Show resolved
Hide resolved
…find .ts files in JIT When the first build in JIT has an error we are not emitting files. This ends up causing an issue because subsequent builds only trigger partial emits of files and only emits the full set of files if the number of files changed is greater than 20. This logic adds the behavior that we only enter the 'only 20 files' part when the previous build was successful. Fixes #14644
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the first build in JIT has an error we are not emitting files. This ends up causing an issue because subsequent builds only trigger partial emits of files and only emits the full set of files if the number of files changed is greater than 20.
This logic adds the behavior that we only enter the 'only 20 files' part when the previous build was successful.
Fixes #14644