fix(@angular-devkit/build-angular): remove prerelease @angular/compiler-cli peer dependency#15780
Merged
mgechev merged 1 commit intoangular:8.3.xfrom Oct 10, 2019
Merged
Conversation
clydin
force-pushed
the
compiler-cli-peer-dep
branch
from
1eeffcd to
4fbc06a
Compare
alan-agius4
approved these changes
Oct 9, 2019
Collaborator
alan-agius4
left a comment
alan-agius4
left a comment
There was a problem hiding this comment.
LGTM, though I think we should also update
…er-cli peer dependency Prerelease versions of the package are not supported and should not be considered valid.
clydin
force-pushed
the
compiler-cli-peer-dep
branch
from
4fbc06a to
c793780
Compare
Collaborator
|
@clydin, can you rebase to make all checks green? |
Member
Author
|
It was. There's an issue with the required check configuration on 8.3.x |
mgechev
approved these changes
Oct 10, 2019
This was referenced Oct 11, 2019
Merged
Closed
This was referenced Oct 17, 2019
Closed
Closed
This was referenced Oct 25, 2019
Merged
Merged
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerelease versions of the
@angular/compiler-clipackage are not supported and should not be considered valid for a stable version of@angular-devkit/build-angular./cc @IgorMinar