fix(vendor): Fix to add concatenated vendors in index.html#165
Merged
filipesilva merged 1 commit intoangular:masterfrom Jan 31, 2016
Merged
fix(vendor): Fix to add concatenated vendors in index.html#165filipesilva merged 1 commit intoangular:masterfrom
filipesilva merged 1 commit intoangular:masterfrom
Conversation
Contributor
|
It looks ok but you and @cironunes are the ones working on it, I don't have as much information as you two. |
Contributor
Author
|
I now tested with "clean npm install", creating new project, linking, and I am pretty sure that this now works. |
Contributor
Author
|
If you check current master its not working, and @cironunes seems to be away at the moment. |
Contributor
|
Let's put it in then. Can't have master not working. |
Contributor
Author
|
I re-checked on master now, and it is working. Thank you. |
Contributor
|
👍 |
Member
|
thanks @jkuri |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@cironunes, @filipesilva please check this soon as master still not working.