Feature/silence sourcemap warnings for vendors#1673
Merged
filipesilva merged 2 commits intoangular:masterfrom Aug 13, 2016
Conversation
This was referenced Aug 15, 2016
TheLarkInn
deleted the
feature/silence_sourcemap_warnings_for_vendors_and_only_pull_vendor_sourcemaps_in_develop_cause_why_need_them_for_prod
branch
| chunks: false, | ||
| chunkModules: false | ||
| chunkModules: false, | ||
| warnings: false |
Contributor
There was a problem hiding this comment.
Isn't that going to remove all warnings? Is there a way to specifically remove source-maps warnings?
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove sourcemap for vendors if in prod, but in develop we will allow it. If a sourcemap isn't properly exposed/inlined (IE: @ngrx/core), the typical warning should be surpressed.
This will also result in faster prod builds
Fixes #1578