fix(@ngtools/webpack): handle union type with a nullable argument#17077
Merged
dgp1130 merged 1 commit intoangular:masterfrom Feb 25, 2020
alan-agius4:union-type-null-ctors
Merged
fix(@ngtools/webpack): handle union type with a nullable argument#17077dgp1130 merged 1 commit intoangular:masterfrom alan-agius4:union-type-null-ctors
dgp1130 merged 1 commit intoangular:masterfrom
alan-agius4:union-type-null-ctors
Conversation
alan-agius4
added
target: patch
Currently constructor parameters with union types that contains nullable argument are not being converted properly and result in broken behaviour. With this change we align the ctor-parameters downlevel transformer to be closer to the NGTSC reflector: https://github.com/angular/angular/blob/master/packages/compiler-cli/src/ngtsc/reflection/src/typescript.ts#L65-L66 This change should also be synced to ng-packagr. Closes: #17063 Reference: FW-1883
clydin
approved these changes
Feb 25, 2020
alan-agius4
added a commit
to ng-packagr/ng-packagr
that referenced
this pull request
Feb 25, 2020
Currently constructor parameters with union types that contains nullable argument are not being converted properly and result in broken behaviour. With this change we align the ctor-parameters downlevel transformer to be closer to the NGTSC reflector: https://github.com/angular/angular/blob/master/packages/compiler-cli/src/ngtsc/reflection/src/typescript.ts#L65-L66 More info: angular/angular-cli#17077
Collaborator
|
Also merged to 9.0.x patch branch. |
Contributor
|
🎉 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently constructor parameters with union types that contains nullable argument are not being converted properly and result in broken behaviour.
With this change we align the ctor-parameters downlevel transformer to be closer to the NGTSC reflector: https://github.com/angular/angular/blob/master/packages/compiler-cli/src/ngtsc/reflection/src/typescript.ts#L65-L66
This change should also be synced to ng-packagr.
Closes: #17063
Reference: FW-1883