fix(karma): set defaults for karma.conf.js#1837
Merged
filipesilva merged 1 commit intoangular:masterfrom Sep 21, 2016
Merged
Conversation
0075d6f to
ad8f1b7
Compare
Contributor
Author
|
Note, I ran into this issue when trying to add the following to the karma.conf.js: With the current karma plugin all webpack and webpackMiddleware configuration in karma.conf.js is overwritten. With this fix the defaults are set for webpack and webpackMiddleware, and any values set in karma.conf.js will also be applied, and/or overwrite the defaults. |
24d64f9 to
371e2c4
Compare
Contributor
Author
|
Cleaned up PR to create variable instead of using inline object. |
a419523 to
914c4a7
Compare
384d459 to
b52886f
Compare
The karma plugin is currently overwriting configuration set in karma.conf.js instead of merging existing values. This fix will set defaults but not overwrite existing configuration.
b52886f to
8baf151
Compare
filipesilva
approved these changes
Sep 21, 2016
abner
pushed a commit
to abner/angular-cli
that referenced
this pull request
Sep 24, 2016
The karma plugin is currently overwriting configuration set in karma.conf.js instead of merging existing values. This fix will set defaults but not overwrite existing configuration.
JJayet
pushed a commit
to JJayet/angular-cli
that referenced
this pull request
Oct 2, 2016
The karma plugin is currently overwriting configuration set in karma.conf.js instead of merging existing values. This fix will set defaults but not overwrite existing configuration.
Closed
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The karma plugin is currently overwriting configuration set in karma.conf.js instead of merging existing values. This fix will set defaults but not overwrite existing configuration.