fix: fix compilation errors for the whole project#1864
Merged
hansl merged 6 commits intoangular:masterfrom Aug 28, 2016
Merged
Conversation
|
CLAs look good, thanks! |
package.json
Outdated
| "build-config-interface": "dtsgen lib/config/schema.json --out lib/config/schema.d.ts", | ||
| "eslint": "eslint .", | ||
| "tslint": "tslint \"**/*.ts\" -c tslint.json -e \"**/blueprints/*/files/**/*.ts\" -e \"node_modules/**\" -e \"tmp/**\"", | ||
| "tslint": "tslint '**/*.ts' -c tslint.json -e '**/blueprints/*/files/**/*.ts' -e 'node_modules/**' -e 'tmp/**' -e 'dist/**'", |
Contributor
There was a problem hiding this comment.
Revert the \" to ' change please. It's a windows compatibility thing, it really needs to be \".
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also uses
ts-nodenow, locally, which is slower but more consistent for sourcemaps and errors.For the next release we will publish javascript files, so speed in typescript will not be an issue.